pantsbuild / pants / 7695
0%
main: 93%

LAST BUILD BRANCH: add-generic-option-to-docker-image
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7695

push

travis-ci

jsirois 
Add `go` and `go-env` goals.

These goals support running arbitrary go commands and arbitrary
third-party commands that respect the $GOROOT and $GOPATH.

In particular, 2 usecases are immediately enabled:
1. Certain enhanced Go editor environments now work with pants Go source
   trees including their 3rdparty deps, two of which this change was
   tested with: The GoSublime plugin for the Sublime Text editor and the
   go-vim plugin for the vim editor.
2. Certain go tooling without direct pants support can be used.  In
   particular `./pants go [targets] -- vet` now runs `go vet` for the
   given targets providing linting for common non-compile-time errors.

Tests are added for these tasks.

Testing Done:
Manually tested with go-vim and sublime via:
```
./pants go-env contrib/go/examples:: -- subl
./pants go-env contrib/go/examples:: -- vim
```

In both cases, the plugins could both browse to 3rdparty code, stdlib code
and symbol completion for these worked as well.  In the case of the stdlib
code, browsing was against the `~/.cache/pants bootstrapped` Go
distribution as would be hoped.

Additionally successfully used the following to vet examples:
```
$ ./pants go contrib/go/examples/:: -- vet
INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants4 on branch jsirois/go/go
.pants.d/go/go/contrib.go.examples.3rdparty.go.github.com.kr.pretty.pretty/src/github.com/kr/pretty/formatter_test.go:46: possible misuse of unsafe.Pointer
exit status 1
.pants.d/go/go/contrib.go.examples.3rdparty.go.github.com.gorilla.mux.mux/src/github.com/gorilla/mux/mux_test.go:1080: arg len(ancestors) for printf verb %s of wrong type: int
exit status 1
.pants.d/go/go/contrib.go.examples.3rdparty.go.gopkg.in.check.v1.check.v1/src/gopkg.in/check.v1/printer.go:89: go/printer.CommentedNode composite literal uses unkeyed fields
.pants.d/go/go/contrib.go.examples.3rdparty.go.gopkg.in.check.v1.check.v1/src/gopkg.in/check.v1/printer.go:162: go/ast.ExprStmt composite literal uses unkeyed fields
.pants.d/go/go/contrib.go.examples.3rdparty.go.gopkg.in.check.v1.check.v1/src/gopkg.in/check.v1/printer.go:162: go/ast.Ellipsis composite literal uses unkeyed fields
.pants.d/go/go/contrib.go.examples.3rdparty.go.gopkg.in.check.v1.check.v1/src/gopkg.in/check.v1/printer.go:167: go/ast.BlockStmt composite literal uses unkeyed fields
exit status 1
...
```

Just running against `contrib/go/examples/src::` produced no errors.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/88444876

Bugs closed: 2476, 2477

Reviewed at https://rbcommons.com/s/twitter/r/3060/
Jobs
ID Job ID Ran Files Coverage
1 7695.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7695.1
4 7695.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7695.4
5 7695.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7695.5
6 7695.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7695.6
7 7695.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7695.7
8 7695.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7695.8
9 7695.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7695.9
10 7695.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7695.10
Source Files on build 7695
Detailed source file information is not available for this build.