pantsbuild / pants / 7686
0%
main: 93%

LAST BUILD BRANCH: go-modcache-named-cache
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7686

push

travis-ci

kwlzn 
Safeguard against stale ProcessManager metadata re-use.

- Add a new pants.util.dirutil.rm_rf helper to safely remove both files and/or directories.
- Improve ProcessManager.purge_metadata().
- Add purge_metadata() calls to daemonization methods to resolve race.
- Test maintenance.

Fixes #2414

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/87760402

---------------------------------------------------------------------------

before:

    [illuminati pants (master)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch master
    INFO] Launched server with pid 55478 at http://localhost:57469
    [illuminati pants (master)]$ kill -9 55478
    [illuminati pants (master)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch master
    INFO] Launched server with pid 55478 at http://localhost:57469
    [illuminati pants (master)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch master
    INFO] Server already running with pid 55546 at http://localhost:57470
    [illuminati pants (master)]$

after:

    [illuminati pants (kwlzn/stale_metadata)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch kwlzn/stale_metadata
    INFO] Launched server with pid 55053 at http://localhost:57390
    [illuminati pants (kwlzn/stale_metadata)]$ kill -9 55053
    [illuminati pants (kwlzn/stale_metadata)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch kwlzn/stale_metadata
    INFO] Launched server with pid 55116 at http://localhost:57392
    [illuminati pants (kwlzn/stale_metadata)]$ PANTS_DEV=1 ./pants server
    INFO] Detected git repository at /Users/kwilson/dev/pants on branch kwlzn/stale_metadata
    INFO] Server already running with pid 55116 at http://localhost:57392

Bugs closed: 2414, 2462

Reviewed at https://rbcommons.com/s/twitter/r/3047/
Jobs
ID Job ID Ran Files Coverage
1 7686.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7686.1
4 7686.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7686.4
5 7686.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7686.5
6 7686.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7686.6
7 7686.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7686.7
8 7686.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7686.8
9 7686.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7686.9
10 7686.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7686.10
Source Files on build 7686
Detailed source file information is not available for this build.