7676
0%
main: 93%

Ran 30 Oct 2015 01:32AM UTC

Jobs 9

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7676

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Adding NpmRun and NpmTest

This addresses #2330 and #2331 - adding support for "test" and "run" goals to Pants.

I would've liked to put an integration test for the "test" goal with a failing test, but I didn't want to check in a failing npm_test target under the examples directory, as it would break using "test contrib/node::". So to do that I have to figure out how to add a new target on the fly in an integration test. The diff is already somewhat large and I was going to put that off.

Note: I talked with @stuhood about the "npm_test" target. I implemented it as described in the design doc (apart from changing its name). We discussed an alternative implementation and how this one could make it more difficult to add the option to resolve targets without their devDependencies in the future. In the end I thought this was a pretty good solution for working with typical Node project structure though, making it easy to adopt Pants. Building a chain of modules without devDependencies is not extremely pressing to me - each target doesn't have its transitive devDependencies under it, just its own, since we're just using "npm install" right now to resolve targets and that doesn't install dependencies' devDependencies.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/88000050

Bugs closed: 2461

Reviewed at https://rbcommons.com/s/twitter/r/3048/

Coverage Stats

Jobs

ID	Job ID	Ran	Coverage
1	7676.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	30 Oct 2015 01:32AM UTC		Travis Job 7676.1
2	7676.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	28 Aug 2017 10:03AM UTC	68.24	Travis Job 7676.2
4	7676.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	30 Oct 2015 01:46AM UTC		Travis Job 7676.4
5	7676.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	30 Oct 2015 01:37AM UTC		Travis Job 7676.5
6	7676.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	30 Oct 2015 01:39AM UTC		Travis Job 7676.6
7	7676.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	30 Oct 2015 01:45AM UTC		Travis Job 7676.7
8	7676.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	30 Oct 2015 01:46AM UTC		Travis Job 7676.8
9	7676.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	30 Oct 2015 01:47AM UTC		Travis Job 7676.9
10	7676.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	30 Oct 2015 01:44AM UTC		Travis Job 7676.10

Source Files on build 7676

Detailed source file information is not available for this build.

pantsbuild / pants / 7676
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7676

pantsbuild / pants / 7676 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7676

pantsbuild / pants / 7676
0%
main: 93%

README BADGES
x