pantsbuild / pants / 7629
0%
main: 93%

LAST BUILD BRANCH: go-pin-gotoolchain
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7629

push

travis-ci

Kris Wilson 
Pave the way for server-side python nailgun components

- Factor out and reimplement NailgunProtocol, a full nailgun protocol implementation which provides for new server-side nailgun components (i.e. the upcoming pants nailgun/Pailgun).
- Implement a util helper RecvBufferedSocket to separate prior buffering logic from the protocol implementation.
- Refactor NailgunSession, NailgunClient & friends to use NailgunProtocol and RecvBufferedSocket.
- Comprehensive test coverage.

Testing Done:
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/87112406

=================================================================================

`PANTS_DEV=1 ./pants clean-all binary examples/src/java::` runs clean locally.

=================================================================================

    ============== test session starts ===============
    platform darwin -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
    plugins: timeout
    collected 38 items

    tests/python/pants_test/java/test_nailgun_protocol.py .................
    tests/python/pants_test/java/test_nailgun_client.py ................
    tests/python/pants_test/util/test_socket.py .....

    =========== 38 passed in 1.49 seconds ============
    Name                                     Stmts   Miss Branch BrMiss  Cover
    --------------------------------------------------------------------------
    src/python/pants/java/nailgun_client       102      3     18      2    96%
    src/python/pants/java/nailgun_protocol      92      1     22      1    98%
    src/python/pants/util/socket                21      0      4      1    96%
    --------------------------------------------------------------------------
    TOTAL                                      215      4     44      4    97%

Bugs closed: 2449

Reviewed at https://rbcommons.com/s/twitter/r/3030/
Jobs
ID Job ID Ran Files Coverage
1 7629.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7629.1
4 7629.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7629.4
5 7629.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7629.5
6 7629.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7629.6
7 7629.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7629.7
8 7629.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7629.8
9 7629.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7629.9
10 7629.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7629.10
Source Files on build 7629
Detailed source file information is not available for this build.