pantsbuild / pants / 7605
0%
main: 93%

LAST BUILD BRANCH: tarek/fix-sandboxer-fd-inheritance
DEFAULT BRANCH: main
Ran
Jobs 1
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7605

push

travis-ci

stuhood 
Ensure synthetic jar is always created (Argument list too long revisited)

https://rbcommons.com/s/twitter/r/2672/ introduced a synthetic that includes original classpath in its manifest, as a workaround for platform limitation: argument too long.

It however wasn't properly triggered because it expects OSError which was wrapped and rethrown by Executor as Executor.Error.

This review makes the following changes

* Use this all time not just on failures, reasoning is prefer one code path rather than two. As you can see, unit test is a lot easier.
* One issue with creating synthetic jar all time is user code may invoke different classLoader that interpret embedded Class-Path differently, because of this, we disabled synthetic jar for scala repl and nailgun (no benefit anyway)
* 2nd issue is previously creating synthetic jar is rare so it was left in a temp directory uncleaned. Now we either clean it up or if caller supplies a directory will save to that directory users can rerun the cmdline if they want to.
* In manifest change from absolute classpath to relative path, to follow the spec, java classLoader is ok with absolute path, but as we discovered some user code doesn't like this [one](https://github.com/twitter/util/blob/develop/util-eval/src/main/scala/com/twitter/util/Eval.scala#L360)

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/86456089

Also tetsed in CI/linux on twitter repo, a due diligence we missed last time.

Bugs closed: 2407

Reviewed at https://rbcommons.com/s/twitter/r/3003/
Jobs
ID Job ID Ran Files Coverage
1 7605.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7605.1
Source Files on build 7605
Detailed source file information is not available for this build.