7586
0%
main: 93%

Ran 23 Oct 2015 10:39PM UTC

Jobs 9

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7586

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Handle case where only transitive dependencies have changed during an incremental build

Because of [#2446](https://github.com/pantsbuild/pants/issues/2446), when you add and remove a dep from a target in succession for a task that uses transitive invalidation, it's possible for an incremental compile to occur in the same `results_dir` as the previous attempt. In that case, we were seeing an error (rightly, as it was an unexpected case) because the previous `results_dir` had not been initialized.

- Work around the bug by always initializing `previous_results_dir`, even if it would be the same as the current `results_dir`
- Add a test that doesn't quite reproduce the issue, and expect it to fail

Testing Done:
Fixes:

    compile(src/scala/org/pantsbuild/zinc:zinc) failed: There is no previous_results_dir for: VT(src.scala.org.pantsbuild.zinc.zinc, invalid)

expected to go green:
https://travis-ci.org/pantsbuild/pants/builds/87097649

Bugs closed: 2447

Reviewed at https://rbcommons.com/s/twitter/r/3028/

Coverage Stats

Jobs

ID	Job ID	Ran	Coverage
1	7586.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	23 Oct 2015 10:39PM UTC		Travis Job 7586.1
3	7586.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	17 Aug 2017 08:02PM UTC	56.96	Travis Job 7586.3
4	7586.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	17 Aug 2017 08:03PM UTC	56.96	Travis Job 7586.4
5	7586.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	23 Oct 2015 10:42PM UTC		Travis Job 7586.5
6	7586.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	23 Oct 2015 10:48PM UTC		Travis Job 7586.6
7	7586.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	23 Oct 2015 10:48PM UTC		Travis Job 7586.7
8	7586.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	23 Oct 2015 10:59PM UTC		Travis Job 7586.8
9	7586.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	23 Oct 2015 10:48PM UTC		Travis Job 7586.9
10	7586.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	23 Oct 2015 10:55PM UTC		Travis Job 7586.10

Source Files on build 7586

Detailed source file information is not available for this build.

pantsbuild / pants / 7586
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7586

pantsbuild / pants / 7586 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7586

pantsbuild / pants / 7586
0%
main: 93%

README BADGES
x