21953
89%

Ran 16 Apr 2021 06:05PM UTC

Jobs 1

Files 442

Run time 3min

Badge

Embed ▾

pending completion

Build # 21953

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

core, grpclb, xds: let leaf LB policies explicitly refresh name resolution when subchannel connection is broken (#8048)

Currently each subchannel implicitly refreshes the name resolution when its state changes to IDLE or TRANSIENT_FAILURE. That is, this feature is built into subchannel's internal implementation. Although it eliminates the burden of having LB implementations refreshing the resolver when connections to backends are broken, this is gives LB policies no chance to disable or override this refresh (e.g., in some complex load balancing hierarchy like xDS, LB policies may embed a resolver inside for resolving backends so the refreshing resolution operation should be hooked to the resolver embedded in the LB policy instead of the one in Channel).

In order to make this transition smoothly, we add a check to SubchannelImpl that checks if the LoadBalancer has explicitly called Helper.refreshNameResolution for broken subchannels created by it. If not, it logs a warning and do the refresh.

A temporary LoadBalancer.Helper API ignoreRefreshNameResolution() is added to avoid false-positive warnings for xDS that intentionally does not want a refresh. Once the migration is done, this should be deleted.

Run Details

26994 of 30637 relevant lines covered (88.11%)

0.88 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	21953.1 (GRADLE_OPTS=-Xmx512m LDFLAGS=-L/tmp/protobuf/lib CXXFLAGS=-I/tmp/protobuf/include LD_LIBRARY_PATH=/tmp/protobuf/lib)	16 Apr 2021 06:05PM UTC	0	88.11	Travis Job 21953.1

Source Files on build 21953

Detailed source file information is not available for this build.

grpc / grpc-java / 21953
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 21953

grpc / grpc-java / 21953 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 21953

grpc / grpc-java / 21953
89%

README BADGES
x