7464
0%
main: 93%

Ran 18 Oct 2015 12:32AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7464

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Remove the global codegen strategy from simple_codegen_task

We had noticed a few issues with versioned target invalidation, first in antlr and then in the newly ported scrooge task. Now that all consumers are ported to isolated codegen, we can fix and prevent those issues by switching away from the manual caching strategy.

- Drop codegen strategies entirely
- Detect duplicate sources using the synthetic targets, rather than re-scanning the workdirs
- Prune duplicate sources from disk when they are "allowed", to avoid having to deal with them in subsequent incremental runs
- Deprecate but preserve the strategy flag
- Enable `cache_target_dirs` for simpler/more-correct caching/invalidation
- In test_simple_codegen_task: move DummyTask and DummyTarget to top level classes in order to add the `ensure_cached` annotation

Testing Done:
https://github.com/pantsbuild/pants/pull/2386

For a context containing 1549 gen targets, the time to execute the task improves signficantly:

    Clean:
      Before: 777 seconds
      After: 220 seconds
    Noop:
      Before: 25 seconds
      After: 12 seconds

Bugs closed: 2337, 2386

Reviewed at https://rbcommons.com/s/twitter/r/2985/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7464.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	18 Oct 2015 12:35AM UTC	Travis Job 7464.1
4	7464.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	18 Oct 2015 12:39AM UTC	Travis Job 7464.4
5	7464.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	18 Oct 2015 12:32AM UTC	Travis Job 7464.5
6	7464.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	18 Oct 2015 12:40AM UTC	Travis Job 7464.6
7	7464.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	18 Oct 2015 12:41AM UTC	Travis Job 7464.7
8	7464.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	18 Oct 2015 12:43AM UTC	Travis Job 7464.8
9	7464.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	18 Oct 2015 12:43AM UTC	Travis Job 7464.9
10	7464.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	18 Oct 2015 12:49AM UTC	Travis Job 7464.10

Source Files on build 7464

Detailed source file information is not available for this build.

pantsbuild / pants / 7464
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7464

pantsbuild / pants / 7464 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7464

pantsbuild / pants / 7464
0%
main: 93%

README BADGES
x