7432
0%
main: 93%

Ran 16 Oct 2015 09:07AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7432

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Fix `buildgen.go --materialize` to act globally.

Previously, when materilizing Go BUILD files, buildgen could err in two
ways:
1. Obsolete BUILD files were left behind.
2. If not all Go targets in the repo were included in the command line
   remote libs with multiple packages might be trimmed to include too
   few packages to support all the Go targets in the repo.

This change adds culling of unused local Go target BUILD files to
partially solve 1 and it forces a global scan of Go source roots when in
`--materialize` mode to solve 2.

Tests are updated to exercise the new global scanning in `--materialize`
mode and local unused BUILD culling.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/85684129

Bugs closed: 2371, 2372, 2381

Reviewed at https://rbcommons.com/s/twitter/r/2977/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7432.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	16 Oct 2015 09:12AM UTC	Travis Job 7432.1
4	7432.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	16 Oct 2015 09:16AM UTC	Travis Job 7432.4
5	7432.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	16 Oct 2015 09:07AM UTC	Travis Job 7432.5
6	7432.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	16 Oct 2015 09:17AM UTC	Travis Job 7432.6
7	7432.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	16 Oct 2015 09:18AM UTC	Travis Job 7432.7
8	7432.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	16 Oct 2015 09:22AM UTC	Travis Job 7432.8
9	7432.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	16 Oct 2015 09:19AM UTC	Travis Job 7432.9
10	7432.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	16 Oct 2015 09:26AM UTC	Travis Job 7432.10

Source Files on build 7432

Detailed source file information is not available for this build.

pantsbuild / pants / 7432
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7432

pantsbuild / pants / 7432 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7432

pantsbuild / pants / 7432
0%
main: 93%

README BADGES
x