pantsbuild / pants / 7389
0%
main: 93%

LAST BUILD BRANCH: csb/new-lockfile-ignore
DEFAULT BRANCH: main
Ran
Jobs 9
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7389

push

travis-ci

jsirois 
Fix mixed classpaths where internal-only is needed.

DetectDuplicates, DxCompile and JarTask all make distinctions in their
processing between internal classpath elements and external ones.
Although DxCompile was handled in 2d515b55, DetectDuplicates and
JarTask were not.  This change fixes the latter two and makes the
handling of the former uniform via a new `ClasspathUtil` helper method
that can return the `internal_classpath`.

The `DuplicateDetectorTest` is re-vamped to cover duplicates between
jars, between internal targets and across both types of targets to
exercise the case that triggered
https://github.com/pantsbuild/pants/issues/2358.

The `BinaryCreateIntegrationTest.test_deploy_excludes` is unmarked fail
as a result of the `JarTask` fix and now successfully tests the case
that triggered https://github.com/pantsbuild/pants/issues/2359.

In the course of adding `ClasspathUtil.internal_classpath`,
`ClasspathUtil.compute_classpath` is removed since it was only called
by `ClasspathUtilTest`.  That test is fixed to exercise the production
codepath used by `JvmCompile`,
`ClasspathUtil.compute_classpath_for_target`.  The unused
`target_closure` is also removed from that method as well as from its
call chain through `JvmCompile`.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/84961315

Bugs closed: 2358, 2359, 2363

Reviewed at https://rbcommons.com/s/twitter/r/2964/
Jobs
ID Job ID Ran Files Coverage
1 7389.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7389.1
3 7389.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
89.58
 Travis Job 7389.3
4 7389.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7389.4
5 7389.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7389.5
6 7389.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7389.6
7 7389.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7389.7
8 7389.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7389.8
9 7389.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7389.9
10 7389.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7389.10
Source Files on build 7389
Detailed source file information is not available for this build.