• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

grpc / grpc-java / 21691
87%
master: 89%

Build:
Build:
LAST BUILD BRANCH: v1.78.x
DEFAULT BRANCH: master
Ran 18 Mar 2021 11:13PM UTC
Jobs 1
Files 430
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
21691

push

travis-ci

ejona86
netty: Add Http2Headers.setLong() for inbound headers

Starting in Netty 4.1.60, Netty will validate Content-Length headers
using getAll() and setLong(). While getAll() was documented as only used
in tests, it doesn't appear it was currently used in any tests.

While Http2NettyTest.contentLengthPermitted() was added to confirm that
Content-Length works, it won't actually exercise any interesting
behavior until we upgrade to Netty 4.1.60. However, I did test with
Netty 4.1.60 and it reproduced the failure in
https://github.com/grpc/grpc-java/issues/7953 and passed with this
change.

Since Netty is now observing/modifying the headers, it would seem
appropriate to implement a substantial portion of the Http2Headers API.
However, the surface is much larger than we'd want to implement for a
'quick fix' that could be backported. In addition, it seems much of the
API is just convenience methods, so it is probably appropriate to split
out a AbstractHeaders class from DefaultHeaders in Netty that doesn't
make any assumptions about the header storage mechanism.

25890 of 29733 relevant lines covered (87.07%)

0.87 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
../context/src/main/java/io/grpc/Deadline.java
2
100.0
../core/src/main/java/io/grpc/internal/DelayedClientCall.java
2
100.0
../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
2
100.0
../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
5
100.0
../core/src/main/java/io/grpc/internal/Http2Ping.java
11
100.0
../netty/src/main/java/io/grpc/netty/GrpcHttp2HeadersUtils.java
Jobs
ID Job ID Ran Files Coverage
1 21691.1 (GRADLE_OPTS=-Xmx512m LDFLAGS=-L/tmp/protobuf/lib CXXFLAGS=-I/tmp/protobuf/include LD_LIBRARY_PATH=/tmp/protobuf/lib) 18 Mar 2021 11:13PM UTC 0
87.07
Travis Job 21691.1
Source Files on build 21691
  • Tree
  • List 430
  • Changed 8
  • Source Changed 1
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Travis Build #21691
  • 39ecbbbc on github
  • Prev Build on v1.35.x (#21678)
  • Next Build on v1.35.x (#21735)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc