21690
88%
master: 89%

Ran 18 Mar 2021 10:57PM CUT

Jobs 1

Files 429

Run time 1min

Badge

Embed ▾

pending completion

Build # 21690

Build Type

push

travis-ci

Committed by

ejona86

Commit Message

netty: Add Http2Headers.setLong() for inbound headers

Starting in Netty 4.1.60, Netty will validate Content-Length headers
using getAll() and setLong(). While getAll() was documented as only used
in tests, it doesn't appear it was currently used in any tests.

While Http2NettyTest.contentLengthPermitted() was added to confirm that
Content-Length works, it won't actually exercise any interesting
behavior until we upgrade to Netty 4.1.60. However, I did test with
Netty 4.1.60 and it reproduced the failure in
https://github.com/grpc/grpc-java/issues/7953 and passed with this
change.

Since Netty is now observing/modifying the headers, it would seem
appropriate to implement a substantial portion of the Http2Headers API.
However, the surface is much larger than we'd want to implement for a
'quick fix' that could be backported. In addition, it seems much of the
API is just convenience methods, so it is probably appropriate to split
out a AbstractHeaders class from DefaultHeaders in Netty that doesn't
make any assumptions about the header storage mechanism.

Run Details

25631 of 29258 relevant lines covered (87.6%)

0.88 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	21690.1 (GRADLE_OPTS=-Xmx512m LDFLAGS=-L/tmp/protobuf/lib CXXFLAGS=-I/tmp/protobuf/include LD_LIBRARY_PATH=/tmp/protobuf/lib)	18 Mar 2021 10:57PM CUT	0	87.6	Travis Job 21690.1

Source Files on build 21690

File	Lines	Relevant	Missed
...ces/src/main/java/io/grpc/services/BinaryLogs.java	53	3	3
...nternalWriteBufferingAndExceptionHandlerUtils.java	35	3	3
...o/grpc/grpclb/InternalGrpclbConstantsAccessor.java	41	2	2
...java/io/grpc/netty/InternalNettySocketSupport.java	46	4	4
...api/src/main/java/io/grpc/InternalCallOptions.java	32	1	1
...java/io/grpc/internal/MigratingThreadDeframer.java	317	137	137
.../grpclb/src/main/java/io/grpc/grpclb/DropType.java	25	3	3
.../main/java/io/grpc/internal/AtomicLongCounter.java	42	6	6
...rpc/netty/InsecureFromHttp1ChannelCredentials.java	31	1	1
...rc/main/java/io/grpc/stub/InternalClientCalls.java	66	15	15

87.6
../

grpc / grpc-java / 21690
88%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 21690

grpc / grpc-java / 21690 88% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 21690

grpc / grpc-java / 21690
88%
master: 89%

README BADGES
x