pantsbuild / pants / 7346
0%
main: 93%

LAST BUILD BRANCH: csb/pex-2.92.0
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7346

push

travis-ci

jsirois 
Support for scanning addresses, implement `list`.

This also introduces a `legacy_python_callbacks_parser` that can work on
most legacy BuildFileAliases with proper configuration.  This is used to
create a self-contained list command that can be used in legacy BUILD
trees (possibly with some `--spec-excludes` to look past trick macros)
to start perf testing aspects of this experimental parsing system
against the 'legacy' (current) system.

Testing Done:
Manually compared the new list command timings with `./pants list`, although
for a more fair comparison, ran both from unzipped pexes, ie:
```
$ ./pants binary \
  src/python/pants/engine/exp/legacy:list \
  src/python/pants/bin:pants_local_binary
$ mkdir dist/pants dist/list && \
  unzip -qd dist/pants dist/pants_local_binary.pex && \
  unzip -qd dist/list dist/list.pex
```

pants list:
```
$ time python2 dist/pants list --spec-excludes=contrib/go/examples list
...
real	0m1.807s
user	0m1.393s
sys	0m0.137s
```

new list:
```
$ time python2 dist/list --pythonpath=$PWD/src/python --spec-excludes=contrib/go/examples
...
real	0m1.103s
user	0m0.983s
sys	0m0.083s

```

These times are representative over many runs with low variance.

It would be great if reviewers could run a similar test on their large trees and report back anecdotes good or bad.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/84431862

Bugs closed: 2308, 2312, 2349

Reviewed at https://rbcommons.com/s/twitter/r/2952/
Jobs
ID Job ID Ran Files Coverage
1 7346.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7346.1
4 7346.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7346.4
5 7346.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7346.5
6 7346.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7346.6
7 7346.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7346.7
8 7346.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7346.8
9 7346.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7346.9
10 7346.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7346.10
Source Files on build 7346
Detailed source file information is not available for this build.