pantsbuild / pants / 7296
0%
main: 93%

LAST BUILD BRANCH: cbs/scope-find-links
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7296

push

travis-ci

stuhood 
Remove the classes_by_target and resources_by_target products

This patch removes the `classes_by_target` and `resources_by_target` products. I also needed to split `compile_classpath` (pre-compile) from `runtime_classpath` (post-compile) in order to allow the ResourceTask subclasses to expose a unique product that wouldn't cycle between themselves or compilation.

- Add `runtime_classpath` which clones the `compile_classpath` and adds compiled classes and resources
- Expand ClasspathUtil to allow walking classpath contents (optionally transitively)
- Remove `classes_by_target` and `resources_by_target` from all tasks, in favor of adding classpath entries
- Skip `jvm_dependency_check` by default (since the previous default checked for an impossible condition in the presence of isolation)
- Fix a bug in `jvm_dependency_usage` tests by setting target roots in the context
- Delete ResourceMapping, since it was only used to register resources which were already being written into a target's classpath
- Replace "fake" classes_by_target deps with real runtime_classpath deps in cases where targets need a runtime classpath
- Adapt ResourceTask to `cache_target_dirs` and drop unnecessary relative_resource_paths
- `dx_compile` now passes classpath entries directly to the dex tool (since it supports consuming jars/zips/directories directly)

Testing Done:
https://github.com/pantsbuild/pants/pull/2311

Bugs closed: 2311

Reviewed at https://rbcommons.com/s/twitter/r/2928/
Jobs
ID Job ID Ran Files Coverage
1 7296.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7296.1
4 7296.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7296.4
5 7296.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7296.5
6 7296.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7296.6
7 7296.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7296.7
8 7296.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7296.8
9 7296.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7296.9
10 7296.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7296.10
Source Files on build 7296
Detailed source file information is not available for this build.