501
92%

Ran 28 Sep 2015 04:20PM UTC

Jobs 42

Files 16

Run time 9min

Badge

Embed ▾

pending completion

Build # 501

Build Type

Pull #853

travis-ci

Committed by

maxjacobson

Commit Message

Only perform error callback when job really failed

This fixes #850, which describes a specific scenario where DJ workers
can crash when the logger fails to log that a job was processed
successfully.

The one downside of this fix is that some messages won't be logged, and
the developer won't know about it. This is why I initially implemented
PR #852 to not rescue those logging exceptions, but it sounds like
keeping the workers alive is more important than knowing if a log
failed. That kind of makes sense to me.

Pull Request Pull Request #853: Only perform error callback when job really failed

Run Details

18 of 18 new or added lines in 2 files covered. (100.0%)

1010 of 1108 relevant lines covered (91.16%)

816.48 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	501.1 (1.9.3, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:20PM UTC	16	90.91	Travis Job 501.1
2	501.2 (2.0.0, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:20PM UTC	16	90.91	Travis Job 501.2
3	501.3 (2.1, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:20PM UTC	16	90.72	Travis Job 501.3
4	501.4 (jruby-19mode, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:21PM UTC	16	91.26	Travis Job 501.4
5	501.5 (jruby-head, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:22PM UTC	16	90.98	Travis Job 501.5
6	501.6 (rbx-2, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:22PM UTC	13	95.0	Travis Job 501.6
7	501.7 (ruby-head, RAILS_VERSION="~> 3.0.0")	28 Sep 2015 04:21PM UTC	16	90.72	Travis Job 501.7
8	501.8 (1.9.3, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:20PM UTC	16	90.72	Travis Job 501.8
9	501.9 (2.0.0, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:20PM UTC	16	90.91	Travis Job 501.9
10	501.10 (2.1, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:20PM UTC	16	90.72	Travis Job 501.10
11	501.11 (jruby-19mode, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:22PM UTC	16	91.34	Travis Job 501.11
12	501.12 (jruby-head, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:23PM UTC	16	90.86	Travis Job 501.12
13	501.13 (rbx-2, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:24PM UTC	13	95.68	Travis Job 501.13
14	501.14 (ruby-head, RAILS_VERSION="~> 3.1.0")	28 Sep 2015 04:22PM UTC	16	90.52	Travis Job 501.14
15	501.15 (1.9.3, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:21PM UTC	16	90.72	Travis Job 501.15
16	501.16 (2.0.0, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:21PM UTC	16	90.91	Travis Job 501.16
17	501.17 (2.1, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:21PM UTC	16	90.52	Travis Job 501.17
18	501.18 (jruby-19mode, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:23PM UTC	16	91.34	Travis Job 501.18
19	501.19 (jruby-head, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:25PM UTC	16	91.06	Travis Job 501.19
20	501.20 (rbx-2, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:24PM UTC	13	95.68	Travis Job 501.20
21	501.21 (ruby-head, RAILS_VERSION="~> 3.2.0")	28 Sep 2015 04:23PM UTC	16	90.72	Travis Job 501.21
22	501.22 (1.9.3, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:22PM UTC	16	90.91	Travis Job 501.22
23	501.23 (2.0.0, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:23PM UTC	16	90.72	Travis Job 501.23
24	501.24 (2.1, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:23PM UTC	16	90.72	Travis Job 501.24
25	501.25 (jruby-19mode, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:24PM UTC	16	91.26	Travis Job 501.25
26	501.26 (jruby-head, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:26PM UTC	16	90.98	Travis Job 501.26
27	501.27 (rbx-2, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:26PM UTC	13	95.49	Travis Job 501.27
28	501.28 (ruby-head, RAILS_VERSION="~> 4.0.0")	28 Sep 2015 04:24PM UTC	16	90.72	Travis Job 501.28
29	501.29 (1.9.3, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:24PM UTC	16	90.72	Travis Job 501.29
30	501.30 (2.0.0, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:24PM UTC	16	90.91	Travis Job 501.30
31	501.31 (2.1, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:24PM UTC	16	90.72	Travis Job 501.31
32	501.32 (jruby-19mode, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:25PM UTC	16	91.33	Travis Job 501.32
33	501.33 (jruby-head, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:27PM UTC	16	91.05	Travis Job 501.33
34	501.34 (rbx-2, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:28PM UTC	13	95.77	Travis Job 501.34
35	501.35 (ruby-head, RAILS_VERSION="~> 4.1.0")	28 Sep 2015 04:25PM UTC	16	90.72	Travis Job 501.35
36	501.36 (1.9.3, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:26PM UTC	16	90.72	Travis Job 501.36
37	501.37 (2.0.0, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:26PM UTC	16	90.91	Travis Job 501.37
38	501.38 (2.1, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:26PM UTC	16	90.72	Travis Job 501.38
39	501.39 (jruby-19mode, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:27PM UTC	16	91.33	Travis Job 501.39
40	501.40 (jruby-head, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:28PM UTC	16	91.05	Travis Job 501.40
41	501.41 (rbx-2, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:29PM UTC	13	95.77	Travis Job 501.41
42	501.42 (ruby-head, RAILS_VERSION="~> 4.2.0")	28 Sep 2015 04:28PM UTC	16	90.72	Travis Job 501.42

Source Files on build 501

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

collectiveidea / delayed_job / 501
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 501

collectiveidea / delayed_job / 501 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 501

collectiveidea / delayed_job / 501
92%

README BADGES
x