7057
0%
main: 93%

Ran 25 Sep 2015 12:12AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7057

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Fix another scoped option issue in the test harnesses

This is another scoped option related issue, besides the ones fixed by
https://rbcommons.com/s/twitter/r/2850/ . The failure is in test_noqa.py, it is
still due to scoped_option used isn't initialized, but the underlying reason
is different.

TaskTestBase provides a way to override `task_type` and use it along with its
option_scope to construct a `testing_task_type`. Note this option_scope is always
a fixed value `test_scope`. The subsequent context call construct scoped
options using `test_scope`.

https://github.com/pantsbuild/pants/pull/2250 has a example call with more details.

From user perspective, for task_type and options_scope to be really
overridable, two things need to happen

* override option_scope earlier, placing it in child test setUp is too late
* actually use the overridden option_scope for test_task_type.options_scope so
  it is not a fix value

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/81723835

Bugs closed: 2250

Reviewed at https://rbcommons.com/s/twitter/r/2870/

Run Details

Jobs

ID	Job ID	Ran
1	7057.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	25 Sep 2015 12:12AM UTC	Travis Job 7057.1
4	7057.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	25 Sep 2015 12:13AM UTC	Travis Job 7057.4
5	7057.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	25 Sep 2015 12:13AM UTC	Travis Job 7057.5
6	7057.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	25 Sep 2015 12:19AM UTC	Travis Job 7057.6
7	7057.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	25 Sep 2015 12:20AM UTC	Travis Job 7057.7
8	7057.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	25 Sep 2015 12:21AM UTC	Travis Job 7057.8
9	7057.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	25 Sep 2015 12:22AM UTC	Travis Job 7057.9
10	7057.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	25 Sep 2015 12:25AM UTC	Travis Job 7057.10

Source Files on build 7057

Detailed source file information is not available for this build.

pantsbuild / pants / 7057
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7057

pantsbuild / pants / 7057 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7057

pantsbuild / pants / 7057
0%
main: 93%

README BADGES
x