7036
0%
main: 93%

Ran 24 Sep 2015 02:29AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7036

Build Type

push

travis-ci

Committed by

ericzundel

Commit Message

Adds a new CONCAT_TEXT rule to jar tool to handle text files that might be missing the last newline.

Insures that non-empty text files always end with a newline.  This handles META-INF/services files that do not end with a newline that appear in the while.

A followon change will publish jar-tool and change pants to use CONCAT_TEXT to modify services files.

Testing Done:
CI running at https://travis-ci.org/pantsbuild/pants/builds/81860566
Added unit tests
Locally, used the jersey-core and jersey-multipart jars which have META-INF/services files with missing newlines:

```
java -jar dist/jar-tool.jar output.jar -jars=./jersey-core-1.19.jar,jersey-multipart-1.19.jar -policies='^META-INF/services/=CONCAT_TEXT'
```

Bugs closed: 2251, 2257

Reviewed at https://rbcommons.com/s/twitter/r/2875/

Run Details

Jobs

ID	Job ID	Ran
1	7036.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	24 Sep 2015 02:29AM UTC	Travis Job 7036.1
4	7036.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	24 Sep 2015 02:33AM UTC	Travis Job 7036.4
5	7036.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	24 Sep 2015 02:34AM UTC	Travis Job 7036.5
6	7036.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	24 Sep 2015 02:36AM UTC	Travis Job 7036.6
7	7036.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	24 Sep 2015 02:37AM UTC	Travis Job 7036.7
8	7036.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	24 Sep 2015 02:40AM UTC	Travis Job 7036.8
9	7036.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	24 Sep 2015 02:41AM UTC	Travis Job 7036.9
10	7036.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	24 Sep 2015 02:44AM UTC	Travis Job 7036.10

Source Files on build 7036

Detailed source file information is not available for this build.

pantsbuild / pants / 7036
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7036

pantsbuild / pants / 7036 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7036

pantsbuild / pants / 7036
0%
main: 93%

README BADGES
x