pantsbuild / pants / 6999
0%
main: 93%

LAST BUILD BRANCH: debug_reapi_test_cache_misses
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6999

push

travis-ci

stuhood 
Fix scoped options initialization in test

This is to fix the task scoped options not being initialized for tests,
discovered from debugging https://rbcommons.com/s/twitter/r/2815/

TL;DR a new option was added to CacheSetup subsystem and subsequently passed to
CacheFactory contructor, previous options are also passed but not used so
failing to pass them in test hasn't caused us any trouble until now.

Two issues in context initialization for scoped options in test, one is
how it is used, the other is in fakes.create_options_for_optionables

* for_task_types is needed so subsystem CacheSetup can be discovered and
initialized.
* For task scopes' with more than two enclosing scopes, like
  `cache.goal1.task1`,  `cache.py.check`, not all enclosing scopes are present.
  In the `cache.goal1.task1` case, the intermediate scope `cache.goal1` is missing.
  This causes `cache.goal1.task1` fail to initialize. Implemented a simplified
  version of `Options.complete_scopes` in `fakes`, so scopes initialization can
  happen in their enclosing order, i.e. `cache`, `cache.goal1`, `cache.goal1.task1`

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/81191336

And with the fix https://rbcommons.com/s/twitter/r/2815/

now passed https://travis-ci.org/peiyuwang/pants/builds/81186394
previously failed https://travis-ci.org/pantsbuild/pants/builds/81072424

I am confused about the coverage drop " Coverage decreased (-1.7%) to 73.86%",
https://coveralls.io/builds/3618389 it's supposed not to change anything
about coverage.

Bugs closed: 2225

Reviewed at https://rbcommons.com/s/twitter/r/2850/
Jobs
ID Job ID Ran Files Coverage
1 6999.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6999.1
4 6999.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6999.4
5 6999.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6999.5
6 6999.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6999.6
7 6999.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6999.7
8 6999.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6999.8
9 6999.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6999.9
10 6999.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6999.10
Source Files on build 6999
Detailed source file information is not available for this build.