pantsbuild / pants / 6921

0%

main: 93%

push

travis-ci

Transition `IvyImports` to 'compile_classpath'.

This kills the last user of the 'jar_dependencies' product and, as a
result, the last extra product of `IvyResolve` - all resolve consumers
now use the 'compile_classpath' `ClasspathProducts`.

To support this, the majority of `IvyResolve.execute` is pulled up into
`IvyTaskMixin.resolve` which now handles population of
`ClasspathProducts` from the lower-level `ivy_resolve`.  Much cleanup
in IvyTaskMixin is now tractable, but left for follow up changes.

The `IvyImports` product is hardened into a custom type and consumers
are updated to use this type and remove some prior hacks no longer
needed.

The 'jar_dependencies' product was the only one to use the `Products`
required predicate mechanism, so that mechanism is removed to bring
`ProductMapping` products in-line with data products.  A subsequent
change can now merge these two types of product into one with identical
handling.

Testing Done:
My machine is setup for the android tests and this ran green:
```
$ ./pants test tests/python/pants_test/android/tasks:{unpack_libraries,unpack_libraries_integration}
...
                     tests/python/pants_test/android/tasks/test_unpack_libraries.py ..............
                     tests/python/pants_test/android/tasks/test_unpack_libraries_integration.py .

                     =========== 15 passed in 3.72 seconds ============
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/80875412

Bugs closed: 1841, 2212

Reviewed at https://rbcommons.com/s/twitter/r/2840/

167 of 167 new or added lines in 14 files covered. (100.0%)

17890 of 23667 relevant lines covered (75.59%)

1.43 hits per line