37078
0%
main: 80%

Ran 30 Dec 2020 10:46PM UTC

Jobs 1

Files 418

Run time 46s

Badge

Embed ▾

pending completion

Build # 37078

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Move to having the Scheduler directly handle SIGINT to cancel all relevant Sessions. (#11399)

### Problem

#11223 moved to using `Session::cancel` to interrupt 1) `InteractiveProcess`, 2) work happening in `Scheduler::execute`.

In the context of `pantsd`, `session.cancel()` is called when the read-half of the `pantsd` connection is closed. When `pantsd` is not used, `ExceptionSink` was expected to run `sessions_cancel_all` to cancel all Sessions.

But as demonstrated in #11359 (and as we previously knew from @gshuflin's work), Python signal handlers do not run until you interact with certain types of Python code... and none of this code was present directly inside of the `Scheduler::execute` loop (although `InteractiveProcess` instances were appropriately interrupted).

### Solution

Move SIGINT handling (for this usecase) out of `ExceptionSink` and into the rust `Scheduler` code in a new `Sessions` struct that cancels all active `Sessions` each time a SIGINT arrives.

### Result

Fixes #11359.

[ci skip-build-wheels]

Run Details

0 of 29047 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	37078.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37)	30 Dec 2020 10:46PM UTC	0	0.0	Travis Job 37078.5

Source Files on build 37078

Detailed source file information is not available for this build.

pantsbuild / pants / 37078
0%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37078

pantsbuild / pants / 37078 0% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37078

pantsbuild / pants / 37078
0%
main: 80%

README BADGES
x