pantsbuild / pants / 6906

0%

main: 93%

push

travis-ci

Ensure stale classes are removed during isolated compile by cleaning classes directory prior to handling invalid targets

Injects a callback into artifact cache inbetween resolving a cached artifact and loading it into the work directory. Jvm isolated compile then provides one that cleans the classes directory on a cache hit.

When the current fingerprint of a compile target doesn't match the one on disk which is managed by the BuildInvalidator, it either will be loaded from cache, or rebuild via the compile tasks. In the case that we would load from cache, we want to ensure that the previous contents of the directory are removed.

Additionally
* changed the name of the zinc java compile integration test since it didn't match the file name.
* added a few tests for `../cache/artifact.py`

Testing Done:
Wrote failing integration test, and made it pass.

CI passing at https://travis-ci.org/pantsbuild/pants/builds/80722631

Bugs closed: 2173, 2176

Reviewed at https://rbcommons.com/s/twitter/r/2805/

50 of 50 new or added lines in 8 files covered. (100.0%)

17914 of 23743 relevant lines covered (75.45%)

1.42 hits per line