37043
0%
main: 80%

Ran 23 Dec 2020 10:56PM UTC

Jobs 1

Files 418

Run time 42s

Badge

Embed ▾

pending completion

Build # 37043

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Explicitly flush stdio in the nailgun client. (#11383)

### Problem

In some cases when `pantsd` is used, stdio is not flushed during successful runs (and failing runs as well, but successful is more unusual). See #11335.

### Solution

Of the buffers listed in https://github.com/pantsbuild/pants/issues/11335#issuecomment-750442644, only the final step (writing to the `tokio::io::std*` handles) does not have a "guaranteed" flush when `Drop` runs, or when the channel is fully consumed. Usually the stdio file handles (`sys::io::std*`) would be torn down on `Drop` during a clean exit of a Rust process, and although their docs claim not to be buffered, their internal implementation is [line buffered by default](https://doc.rust-lang.org/src/std/io/stdio.rs.html#489).

But Pants clients exit with `sys.exit`, and that likely bypasses `Drop` for statics. So: explicitly flush `tokio::io::std*` before exiting the client code.

[ci skip-build-wheels]

Run Details

0 of 29070 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	37043.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37)	23 Dec 2020 10:56PM UTC	0	0.0	Travis Job 37043.5

pantsbuild / pants / 37043
0%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37043

pantsbuild / pants / 37043 0% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37043

pantsbuild / pants / 37043
0%
main: 80%

README BADGES
x