36959
0%
main: 80%

Ran 20 Dec 2020 01:27AM UTC

Jobs 1

Files 417

Run time 30s

Badge

Embed ▾

pending completion

Build # 36959

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

avoid unnecessary copy in cache code path (#11348)

### Problem

https://github.com/pantsbuild/pants/pull/11344 introduced a `.to_bytes()` helper for protobuf messages. However, in one spot, this introduced a unnecessary copy because the result is converted to a `Vec<u8>` immediately.

### Solution

Remove the unnecessary copy by encoding into a `Vec<u8>` directly. 

It might be possible to switch the `PlatformAndResponseBytes` struct to use `Bytes` instead of `Vec<u8>` but that would require reasoning about whether it would change the format of the struct when stored in the cache, which I want to avoid having to do for now.

### Result

Existing tests pass.

Run Details

0 of 28919 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	36959.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37)	20 Dec 2020 01:27AM UTC	0	0.0	Travis Job 36959.5

Source Files on build 36959

Detailed source file information is not available for this build.

pantsbuild / pants / 36959
0%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36959

pantsbuild / pants / 36959 0% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36959

pantsbuild / pants / 36959
0%
main: 80%

README BADGES
x