36939
0%
main: 80%

Ran 19 Dec 2020 04:10AM UTC

Jobs 1

Files 417

Run time 40s

Badge

Embed ▾

pending completion

Build # 36939

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

use Bytes instead of Vec<u8> for protobuf binary fields (#11342)

### Problem

https://github.com/pantsbuild/pants/pull/11307 upgraded the gRPC code to [Tonic](https://github.com/hyperium/tonic) from grpcio. As part of that upgrade, Pants now uses [Prost](https://github.com/danburkert/prost) to generate Rust structs for protobuf types. By default, Prost encodes binary fields as `Vec<u8>`. Given the attendant problems of `Vec<u8>` of needing to copy around bytes when structs are cloned, the more efficient method is to use `Bytes` for the representation to avoid unnecessary copies.

### Solution

Upgrade Prost to https://github.com/danburkert/prost/commit/a1cccbcee and enable using `Bytes` for all binary fields.

### Result

Existing tests pass.

Run Details

0 of 28892 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	36939.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37)	19 Dec 2020 04:10AM UTC	0	0.0	Travis Job 36939.5

Source Files on build 36939

Detailed source file information is not available for this build.

pantsbuild / pants / 36939
0%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36939

pantsbuild / pants / 36939 0% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36939

pantsbuild / pants / 36939
0%
main: 80%

README BADGES
x