pantsbuild / pants / 6799
0%
main: 93%

LAST BUILD BRANCH: update_setup_protoc
DEFAULT BRANCH: main
Ran
Jobs 10
Files 388
Run time 9min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6799

push

travis-ci

gmalmquist 
Make BootstrapJvmTools fail fast on a bad user-specified address.

Previously, if you specified a target for a jvm-tool that pants
failed to resolve, if the jvm-tool had a default classpath, pants
would simply inject a synthetic JarLibrary with the same name that
used the default classpath.

This resulted in pants pretending to use the user-specified target
that it couldn't find, but silently it was using the default.

This caused problems for square internally when we tried to specify
a different version of the wire-compiler with an (unwittingly)
malformatted spec. The build continued along merrily and subtly
pulled in the wrong version of wire, only blowing up when it tried
to compile a target that used features not available in pants's
default version of wire.

Example output after this change:

    ~/Src/Pants ./pants --gen-wire-wire-compiler="this-target-definitely-does-not-exist" clean-all compile examples/src/wire::
    INFO] Detected git repository at /Users/gmalmquist/Src/Pants on branch gmalmquist/missing-jvm-tool-options-fail-loudly

    17:41:55 00:00 [main]
                   (To run a reporting server: ./pants server)
    17:41:55 00:00   [bootstrap]
    17:41:55 00:00   [setup]
    17:41:55 00:00     [parse]
    FAILURE: Failed to resolve target for tool: this-target-definitely-does-not-exist. This target was obtained from
    option wire-compiler in scope gen.wire.

    Make sure you didn't make a typo in the tool's address. You specified that the
    tool should use the target found at "this-target-definitely-does-not-exist".

    This target has a default classpath configured, so you can simply remove:
      [gen.wire]
      wire-compiler: this-target-definitely-does-not-exist
    from pants.ini (or any other config file) to use the default tool.

    The default classpath is: com.squareup.wire-wire-compiler-1.6.0

    Note that tool target addresses in pants.ini should be specified *without* quotes.

    17:41:55 00:00   [complete]
                   FAILURE

Testing Done:
Manual testing, added tests to test_bootstrap_jvm_tools_integration.

CI went green here: https://travis-ci.org/gmalmquist/pants/builds/79863183
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/79869416

Bugs closed: 2167

Reviewed at https://rbcommons.com/s/twitter/r/2795/

17667 of 23402 relevant lines covered (75.49%)

1.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6799.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6799.1
2 6799.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
71.14
 Travis Job 6799.2
3 6799.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
71.54
 Travis Job 6799.3
4 6799.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6799.4
5 6799.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6799.5
6 6799.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6799.6
7 6799.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6799.7
8 6799.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6799.8
9 6799.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6799.9
10 6799.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6799.10
Source Files on build 6799
Detailed source file information is not available for this build.