pantsbuild / pants / 6755
0%
main: 93%

LAST BUILD BRANCH: shell-completion-fs
DEFAULT BRANCH: main
Ran
Jobs 10
Files 387
Run time 9min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6755

push

travis-ci

jsirois 
Introduce anonymous targets built by macros.

This change introduces a new `TargetMacro.Factory` type whose instances
are accepted in the `BuildFileAliases` "targets" slot that can restrict
targets to only being contructed via the context aware object factory
interface, aka: BUILD file target macros.  This allows a target author to
be more restrictive with a target's arguments.  Two cases are immediately
important:

1. Enforcing 1:1:1
   This requires taking away the ability of the BUILD file author to
   specify a target name to ensure each BUILD file can have only 1
   target.  Since name is integral to Target capture, only a macro can
   do this.
2. Enforcing no dependencies
   The need to do this at all should go away when BuildGraph handling of
   non-Target Addressables is supported; but, until then, dependencies
   is another low-level property of Targets that cannot otherwise be
   blocked from population by BUILD file authors.

In the course of adding support for anonymous targets, the limits of the
existing system of carrying around type alias metadata in
BuildFileAddress were reached, and so this attribute was re-plumbed
through the Addressable proxies and into Target directly, allowing
macros to specify the alias for anonymous targets they create.

Finally, the BuildFileTargetFactory was lifted up as a small interface to
abstract the role both macros and target proxies serve in SourceRoot
specification and an explicit Macro type was introduced to allow for
macros to back restricted source roots.

Testing Done:
The contrib/go/examples BUILD tree was regenerated with the updated
`GoBuildgen` task via:
`$ ./pants buildgen.go --materialize --remote contrib/go/examples::`

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/79408257

Bugs closed: 2019, 2123

Reviewed at https://rbcommons.com/s/twitter/r/2759/

17592 of 23308 relevant lines covered (75.48%)

1.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6755.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6755.1
2 6755.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
71.31
 Travis Job 6755.2
3 6755.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
71.41
 Travis Job 6755.3
4 6755.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6755.4
5 6755.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6755.5
6 6755.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6755.6
7 6755.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6755.7
8 6755.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6755.8
9 6755.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6755.9
10 6755.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6755.10
Source Files on build 6755
Detailed source file information is not available for this build.