36593
0%
main: 80%

Ran 20 Nov 2020 07:17PM UTC

Jobs 1

Files 431

Run time 45s

Badge

Embed ▾

pending completion

Build # 36593

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Revert premature deprecation of `sources` field for `python_awslambda` (#11216)

While the `sources` field results in lots of issues, we did not offer an adequate replacement - there is more boilerplate now.

We likely should still deprecate the `sources` field, but we can do much better. For example, we can teach the `handler` field to allow for a source file, which we then convert into the handler module. Then, we can use dependency inference to avoid the user having to specify `dependencies`.

Status quo, with the deprecation in place:

```python
python_library()

python_awslambda(
  name="lambda",
  handler="path.to.lambda:func",
  dependencies=["./lambda.py"],
)
```

After, with still deprecating, but with the proposed improvements:

```python
python_library()

python_awslambda(
  name="lambda",
  handler="lambda.py:func",
)
```

This new feature shouldn't go into 2.0, so we for now revert the deprecation.

We still keep the bug fix of enforcing that `sources` is <=1 file.

Run Details

0 of 29912 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	36593.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	20 Nov 2020 07:17PM UTC	0	0.0	Travis Job 36593.5

Source Files on build 36593

Detailed source file information is not available for this build.

pantsbuild / pants / 36593
0%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36593

pantsbuild / pants / 36593 0% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 36593

pantsbuild / pants / 36593
0%
main: 80%

README BADGES
x