pantsbuild / pants / 6458
0%
main: 93%

LAST BUILD BRANCH: pyo3/upgrade-v0.28.3
DEFAULT BRANCH: main
Ran
Jobs 10
Files 375
Run time 12min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6458

push

travis-ci

gmalmquist 
Requiring explicit dependency on the DistributionLocator subsystem.

This includes adding DistributionLocator as subsystem dependency of
IvySubsystem, and requiring a distribution input to execute_java in
pants.java.util.

The latter change is obviously the more distruptive, and due to how
the default parameters work, it is difficult to see that
distribution is necessary when trying to use that function, unless
you read the pydocs carefully.

To alleviate this, I've added an execute_java method to
Distribution, which just calls util.execute_java, passing itself
as the distribution.

This way, instead of importing pants.java.util, you just import
DistributionLocator, and use something like:

    DistributionLocator.cached().execute_java(...)

Which is more verbose, but requires one less import and makes it
obvious that you need a subsystem dependency on
DistributionLocator.

It makes sense to me that the Distribution should be able to invoke
its own java binary, and the actual meat-and-potatoes code is still
in pants.java.util, so I don't think this pollutes the primarily
information-holder functionality of Distribution too much. But I am
open to changing it if people find it offensive.

Regardless, this change also has the nice side-effect of making it
much more explicit that you're using an arbitrary cached version of
the jvm whenever you run java, which should make it easier and more
maintainable to use more constrained versions if necessary.

Testing Done:
Added unit tests to pants_test/java/test_executor.py.

CI went green here: https://travis-ci.org/gmalmquist/pants/builds/77366143

Bugs closed: 2072

Reviewed at https://rbcommons.com/s/twitter/r/2707/

16814 of 22509 relevant lines covered (74.7%)

1.41 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6458.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6458.1
2 6458.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
70.46
 Travis Job 6458.2
3 6458.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
70.19
 Travis Job 6458.3
4 6458.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6458.4
5 6458.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6458.5
6 6458.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6458.6
7 6458.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6458.7
8 6458.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6458.8
9 6458.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6458.9
10 6458.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6458.10
Source Files on build 6458
Detailed source file information is not available for this build.