pantsbuild / pants / 35824

0%

main: 80%

push

travis-ci-com

use libCST to parse imports from python 3 code (#10907)

### Problem

Fixes #10894.

### Solution

- Add `libcst>=0.3.12,<0.4` to `requirements.txt`.
- Remove the usage of the normal python 3 `ast` library from `import_parser.py`, and implement a `_CSTVisitor` to visit import nodes.
- When using python 3, instead use the `_CSTVisitor`.
  - We use python 3.8 to parse all python 3 code, which is 100% correct for the purpose of parsing imports.

### Result

We should no longer be dependent on the version of the current python executable to parse python code for dependencies!

89 of 89 new or added lines in 2 files covered. (100.0%)

0 of 29406 relevant lines covered (0.0%)

0.0 hits per line