• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 35799
0%
main: 93%

Build:
Build:
LAST BUILD BRANCH: automation/release/2.32.0.dev2
DEFAULT BRANCH: main
Ran 06 Oct 2020 06:11PM UTC
Jobs 1
Files 430
Run time 52s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
35799

push

travis-ci-com

web-flow
Add `await Get(Addresses, UnparsedAddressInputs)`  (#10913)

### Problem

There are now ~dozen instances where we allow the user to specify an address somewhere other than the `dependencies` field, such as options like `--protoc-runtime-targets`.

We had lots of duplication for parsing these raw string values. Likewise, every single implementation failed to handle subprojects correctly.

### Solution

Factor up a new `UnparsedAddressInputs` type. This stores strings, rather than `AddressInput`, so that we can make sure we consider subprojects correctly without callers needing to know this exists.

This is a much simpler implementation than the dependencies field, e.g. not allowing for `!` and `!!` ignores.

[ci skip-rust]
[ci skip-build-wheels]

57 of 57 new or added lines in 14 files covered. (100.0%)

0 of 29285 relevant lines covered (0.0%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
4 35799.4 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36) 06 Oct 2020 06:11PM UTC 0
0.0
Travis Job 35799.4
Source Files on build 35799
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #35799
  • 45c44f6b on github
  • Prev Build on master (#35796)
  • Next Build on master (#35807)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc