pantsbuild / pants / 6421
0%
main: 93%

LAST BUILD BRANCH: rust-deps
DEFAULT BRANCH: main
Ran
Jobs 10
Files 373
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6421

push

travis-ci

jsirois 
Fix PythonThriftBuilder to operate on 1 target.

Previously it operated on the closure of thrift files depended on by a
single PythonThriftLibrary and this trampled on work both PythonChroot
and SetupPy did to walk the closure and link together CodeGenerator
outputs.  This brings PythonThriftBuilder into line PythonAntlrBuilder
and fixes 2 bugs.

Tests are added that fail before the fix and pass after.

Testing Done:
After adding the 2 tests but before the fix:
```console
$ ./pants test tests/python/pants_test/backend/python/tasks/:setup_py -- -vktest_exported_thrift_issues_2005
...
         with extracted_sdist(target2, 'test.exported_dependee-0.0.0') as (py_files, path):
           self.assertEqual({path('setup.py'),
                             path('src/__init__.py'),
                             path('src/exported_dependee/__init__.py'),
                             path('src/exported_dependee/constants.py'),
                             path('src/exported_dependee/ttypes.py')},
 >                          py_files)
 E         AssertionError: Items in the second set but not the first:
 E         '/tmp/tmpMLYtFG/test.exported_dependee-0.0.0/src/exported/constants.py'
 E         '/tmp/tmpMLYtFG/test.exported_dependee-0.0.0/src/exported/__init__.py'
 E         '/tmp/tmpMLYtFG/test.exported_dependee-0.0.0/src/exported/ttypes.py'
...
```

```console
$ ./pants test tests/python/pants_test/backend/python:python_chroot -- -vktest_thrift_issues_2005
...
 tests/python/pants_test/backend/python/test_python_chroot.py:200: in do_test_thrift
     inspect_chroot(python_chroot)
 tests/python/pants_test/backend/python/test_python_chroot.py:241: in inspect_chroot
     self.assertEqual(2, len(all_constants_files))
 E   AssertionError: 2 != 3
...
```

Both green after the fix.

This pants also works on the test Wyatt created on the thrift-include
branch of https://github.com/wyattanderson/pantstest

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/77183330

Bugs closed: 2005, 2054, 2062

Reviewed at https://rbcommons.com/s/twitter/r/2696/

16769 of 22427 relevant lines covered (74.77%)

1.41 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6421.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6421.1
2 6421.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
70.54
 Travis Job 6421.2
3 6421.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
70.24
 Travis Job 6421.3
4 6421.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6421.4
5 6421.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6421.5
6 6421.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6421.6
7 6421.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6421.7
8 6421.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6421.8
9 6421.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6421.9
10 6421.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6421.10
Source Files on build 6421
Detailed source file information is not available for this build.