35757
0%
main: 93%

Ran 03 Oct 2020 07:48AM UTC

Jobs 1

Files 430

Run time 29s

Badge

Embed ▾

pending completion

Build # 35757

Build Type

cron

travis-ci-com

Committed by

web-flow

Commit Message

Add a FileDigest type to differentiate file APIs from directory APIs (#10900)

### Problem

Two codepaths in our `@rule` API use a `Digest` for a file rather than a directory, and this can cause confusion, since using a `Digest` of the wrong type will trigger a failure to lookup a digest in storage. More generally, our Python API has so far been _more_ typesafe than our Rust API with regard to `Digest`s: fairly consistently using them to represent `Directory`s.

### Solution

Introduce `FileDigest`, and use it in the two relevant locations:
1. `DownloadFile` takes the `FileDigest` for the file being downloaded.
2. `single_file_digests_to_bytes` takes `FileDigests` returned in `workunits.artifacts` (see #10698).

### Result

Improved type safety and clarity. Fixes #10898.

[ci skip-build-wheels]

Run Details

0 of 29259 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	35757.4 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py37)	03 Oct 2020 07:48AM UTC	0	0.0	Travis Job 35757.4

Source Files on build 35757

Detailed source file information is not available for this build.

pantsbuild / pants / 35757
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35757

pantsbuild / pants / 35757 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35757

pantsbuild / pants / 35757
0%
main: 93%

README BADGES
x