pantsbuild / pants / 35611
0%
main: 93%

LAST BUILD BRANCH: tdyas/reapi/migrate-to-output-paths
DEFAULT BRANCH: main
Ran
Jobs 1
Files 437
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
35611

push

travis-ci-com

web-flow 
<a href="https://github.com/pantsbuild/pants/commit/<a class=hub.com/pantsbuild/pants/commit/209e9aa39d89ddf6b5b8fa27bcd46e2c21ec5927">209e9aa39<a href="https://github.com/pantsbuild/pants/commit/209e9aa39d89ddf6b5b8fa27bcd46e2c21ec5927">&quot;&gt;Validate the names of directory children, and normalize output directory/file names (#10850)

### Problem

As explained in https://github.com/pantsbuild/pants/issues/10802#issuecomment-697922102, Pants does not currently normalize `Process::{output_files,output_directories}` as relative paths, which caused us to send an [invalid path](https://github.com/bazelbuild/remote-apis/blob/</a><a class="double-link" href="https://github.com/pantsbuild/pants/commit/<a class="double-link" href="https://github.com/pantsbuild/pants/commit/f54876595da9f2c2d66c98c318d00b60fd64900b">f54876595</a>">f54876595</a><a href="https://github.com/pantsbuild/pants/commit/209e9aa39d89ddf6b5b8fa27bcd46e2c21ec5927">/build/bazel/remote/execution/v2/remote_execution.proto#L507-L508) to the server. Additionally, the server managed to return a &quot;nearly valid&quot; output where a child path for a directory had an empty name, which we should validate for in order to fail faster.

### Solution

In two commits: 1) validate that `Directory` protos returned by remoting do not contain empty child names, 2) switch the `Process::{output_files,output_directories}` fields to holding `RelativePath`s, which are normalized to strip trailing slashes, and validated as not escaping their root.

### Result

Fixes #10802. Opened https://github.com/bazelbuild/remote-apis/issues/175 to track upstreaming the additional "must be non-empty" constraint.

[ci skip-build-wheels]

0 of 29486 relevant lines covered (0.0%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
5 35611.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36) 0
0.0
 Travis Job 35611.5
Source Files on build 35611
Detailed source file information is not available for this build.