35586
0%
main: 93%

Ran 24 Sep 2020 02:40AM UTC

Jobs 1

Files 437

Run time 1min

Badge

Embed ▾

pending completion

Build # 35586

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Fix --pants-ignore-warnings behavior (#10845)

### Problem

cf. https://github.com/pantsbuild/pants/issues/9938 , the infrastructure for ignoring warnings with the `--pants-ignore-warnings` option is broken in the pantsd case, not correctly filtering warnings that are triggered in options initialization code (and also printing multiple instances of the same warning, regardless of whether or not pantsd is running). 

### Solution

The root cause of these problems are that the ignore filters set up by `--pants-ignore-warnings` can only be configured after bootstrap option parsing has already happened, so any warnings set up before this are currently being printed. This commit makes use of the `warnings.catch_warnings` context manager, which suppresses warning messages within the context, to temporarily suppress the unwanted emissions of warning message before `setup_warning_filtering` is called. Additionally it is necessary to add a call to `setup_warning_filtering`, which has been modified to reset warning filters before (re)configuring them, in the pantsd core code. This commit also removes the no-longer-used `ensure_stderr` option from `warn_or_error`.

Coverage Stats

0 of 29488 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	35586.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	24 Sep 2020 02:40AM UTC	0	0.0	Travis Job 35586.5

Source Files on build 35586

Detailed source file information is not available for this build.

pantsbuild / pants / 35586
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35586

pantsbuild / pants / 35586 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35586

pantsbuild / pants / 35586
0%
main: 93%

README BADGES
x