35575
0%
main: 93%

Ran 23 Sep 2020 11:51PM UTC

Jobs 1

Files 437

Run time 3min

Badge

Embed ▾

pending completion

Build # 35575

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Refactor `core/util_rules/archive.py` to use `BinaryPaths` (#10836)

At the time this code was added, we didn't have `BinaryPaths`. This change brings a couple improvements:

* We now use `CreateDigest` to create the empty directory, rather than `mkdir`.
* We no longer require `/bin/bash` existing.
* We use tests to verify that each binary is valid, e.g. not malicious, by running `--version`.
* The cache will be invalidated if the programs change.
    * Almost certainly, the output digest will still be the same, so downstream rules would not need to rerun. 
* We run via absolute paths, which is important for compliance with the RE spec.

This also unblocks some MyPy work, where we need to unzip a Pex.

[ci skip-build-wheels]
[ci skip-rust]

Coverage Stats

0 of 29485 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	35575.4 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	23 Sep 2020 11:51PM UTC	0	0.0	Travis Job 35575.4

Source Files on build 35575

Detailed source file information is not available for this build.

pantsbuild / pants / 35575
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35575

pantsbuild / pants / 35575 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35575

pantsbuild / pants / 35575
0%
main: 93%

README BADGES
x