6304
0%
main: 93%

Ran 20 Aug 2015 02:30PM UTC

Jobs 10

Files 353

Run time 8min

Badge

Embed ▾

pending completion

Build # 6304

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Remove log options from the zinc Setup to fix performance issue

The `Setup` object is used as a cache key for compiler instances, and it turns out that missing the cache for compiler instances causes a more than 2x slowdown. In this case, as soon as the filters were non-empty, the `Regex` object would fail to match (doesn't implement equals.)

- Remove log options from the Setup, since they are passed into the compile method each time anyway.

Testing Done:
https://github.com/pantsbuild/pants/pull/2031

manually verified that the slowdown with filters is gone, and that filtering still works

Reviewed at https://rbcommons.com/s/twitter/r/2666/

Coverage Stats

15873 of 21444 relevant lines covered (74.02%)

1.39 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6304.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 Aug 2015 02:31PM UTC		Travis Job 6304.1
2	6304.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	20 Aug 2015 02:31PM UTC	69.99	Travis Job 6304.2
3	6304.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	20 Aug 2015 02:33PM UTC	69.42	Travis Job 6304.3
4	6304.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 Aug 2015 02:30PM UTC		Travis Job 6304.4
5	6304.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 Aug 2015 02:33PM UTC		Travis Job 6304.5
6	6304.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 Aug 2015 02:39PM UTC		Travis Job 6304.6
7	6304.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 Aug 2015 02:38PM UTC		Travis Job 6304.7
8	6304.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 Aug 2015 02:37PM UTC		Travis Job 6304.8
9	6304.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	20 Aug 2015 02:39PM UTC		Travis Job 6304.9
10	6304.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 Aug 2015 02:38PM UTC		Travis Job 6304.10

Source Files on build 6304

Detailed source file information is not available for this build.

pantsbuild / pants / 6304
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6304

pantsbuild / pants / 6304 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6304

pantsbuild / pants / 6304
0%
main: 93%

README BADGES
x