35476
0%
main: 93%

Ran 17 Sep 2020 06:11PM UTC

Jobs 1

Files 434

Run time 1min

Badge

Embed ▾

pending completion

Build # 35476

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Remove reset_interactive_output_stream (#10791)

### Problem

`ExceptionSink.reset_interactive_output_stream` is a legacy codepath that touches some class variables in `ExceptionSink` as well as pants initialization code in both the pantsd and no-pantsd cases. The only case where this code is relevant is in the custom singal handler for SIGUSR2, where the python standard library `faulthandler` module was being used to optionally print a Python stack trace when that signal was received (which is also an undocumented piece of functionality).

### Solution

This commit removes that code path entirely, which allows us to simplify `ExceptionSink` and remove a dependency on `ExceptionSink` in several places. 

cf. https://github.com/pantsbuild/pants/issues/10792 , we may want to re-introduce the functionality to send pants some kind of signal to output a live stack trace. However, if we do this, we should re-implement the feature in a way that is aware of the Rust engine (and useful for debugging Rust as well as Python issues), and make sure that we document it.

Coverage Stats

0 of 29424 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	35476.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	17 Sep 2020 06:11PM UTC	0	0.0	Travis Job 35476.5

Source Files on build 35476

Detailed source file information is not available for this build.

pantsbuild / pants / 35476
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35476

pantsbuild / pants / 35476 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35476

pantsbuild / pants / 35476
0%
main: 93%

README BADGES
x