35388
0%
main: 93%

Ran 14 Sep 2020 06:55PM UTC

Jobs 1

Files 434

Run time 42s

Badge

Embed ▾

pending completion

Build # 35388

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

remoting: move target_platform property into environment variable (#10713)

### Problem

Pants currently sets a `target_platform` property automatically in the platform properties of remote execution requests. This property does not use the name or semantics of what the REv2 protocol suggests (i.e., the `OSFamily` property). 

Moreover, the fact that this property can be set to multiple values in the same run (e.g. `linux` and `none`) interferes with setting up workers on the server side, especially for Buildbarn which allocates work based on an exact match to platform properties and Buildgrid which just fails for a worker to pick up the work if the second unconfigured property is seen.

See discussion in https://github.com/pantsbuild/pants/issues/10010 for more information.

### Solution

Move the `target_platform` property on remote execution requests into an environment variable so it does not implicate platform property semantics on the server but still is in the cache key.

### Result

Updated tests pass.

Coverage Stats

0 of 29363 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	35388.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	14 Sep 2020 06:55PM UTC	0	0.0	Travis Job 35388.5

Source Files on build 35388

Detailed source file information is not available for this build.

pantsbuild / pants / 35388
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35388

pantsbuild / pants / 35388 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35388

pantsbuild / pants / 35388
0%
main: 93%

README BADGES
x