pantsbuild / pants / 6255
0%
main: 93%

LAST BUILD BRANCH: fix/rust-dockerfile-parser-fails-on-base-image-with-hash-build-arg
DEFAULT BRANCH: main
Ran
Jobs 10
Files 352
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6255

push

travis-ci

gmalmquist 
Speeding up jvm-platform-validate step.

Using self.invalidated mechanism, targets are only re-evaluated if
they (1) they failed previously, (2) their dependencies have changed,
or (3) their platform -target version has changed.

Additionally, pruned down the list of dependencies that must be
considered for each target. Instead of evaluating all transitive
JvmTarget dependencies, only consider the "direct" JvmTarget
dependencies. "Direct" is in quotes because I'm defining a JvmTarget
'A' as "directly" depending on a JvmTarget 'B' iff there exists a
path in the dependency graph from 'A' to 'B', and there are no
internal vertices in the path that are JvmTargets.

This behavior is documented in the jvm_dependency_map property.

This addresses https://github.com/pantsbuild/pants/issues/1972. It'd probably be good for someone with access to test this change against the repos which were previously experiencing slow-down from jvm-platform-validate, to make sure this patch actually solves the problem.

Testing Done:
Manual testing implies caching is working as intended. Added a couple unit tests to test_jvm_platform_analysis.py. Everything passes locally.

CI went green: https://travis-ci.org/pantsbuild/pants/builds/75650551
CI went green: https://travis-ci.org/pantsbuild/pants/builds/75940854
CI went green: https://travis-ci.org/pantsbuild/pants/builds/76001873

Bugs closed: 1981

Reviewed at https://rbcommons.com/s/twitter/r/2626/

15785 of 21361 relevant lines covered (73.9%)

1.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6255.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6255.1
2 6255.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
68.81
 Travis Job 6255.2
3 6255.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
70.33
 Travis Job 6255.3
4 6255.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6255.4
5 6255.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6255.5
6 6255.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6255.6
7 6255.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6255.7
8 6255.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6255.8
9 6255.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6255.9
10 6255.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6255.10
Source Files on build 6255
Detailed source file information is not available for this build.