pantsbuild / pants / 6192
0%
main: 93%

LAST BUILD BRANCH: upgrade_runson_to_ami-0a3c71582153db678
DEFAULT BRANCH: main
Ran
Jobs 10
Files 351
Run time 11min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6192

push

travis-ci

jsirois 
Elevate the pants version to a 1st class option.

Currently `pants_version` is a config option relied on by pants tooling
but not formalized as a registered option in the pants codebase.  This
change lifts all forms of pants version (`-V`, `--version` and the new
`--pants-version`) to be a global option.  The option is configured to
work as both a 0-arg command-line flag to trigger version help printing
as well as an option to use for setting the desired pants_version in
pants.ini (or via an the PANTS_VERSION env var).  The pantsbuild/setup
script and other proprietary pants bootstrap scripts use this option to
bootstrap pants to the requested version today and in the future pants
itself will use the version in this way.

Testing Done:
Verified a 4x speed improvement in `./pants --version`! - heh.

Verified pants_version is picked up as a pants.ini option like so:
```diff
$ git diff -U1 pants.ini
diff --git a/pants.ini b/pants.ini
index a557fbf..8b2eeea 100644
--- a/pants.ini
+++ b/pants.ini
@@ -11,2 +11,4 @@
 [DEFAULT]
+pants_version: jake
+
 print_exception_stacktrace: True
```
```console
$ ./pants -V
0.0.41
$ ./pants -h | grep version
-V=<str>, --pants-version=<str>, --version=<str> (default: jake)
    Prints pants' version number and exits.
```

Note that the real version of pants is printed when -V is requested
on the CLI, but the configured pants_version print as the default in
help output.  Once pantsbuild/setup (next change) and, in the future,
pants itself uses pants_version to bootstrap the proper pants version
this will always align as expected.

CI is away here:
  https://travis-ci.org/pantsbuild/pants/builds/75679069

Bugs closed: 1983

Reviewed at https://rbcommons.com/s/twitter/r/2627/

15679 of 21210 relevant lines covered (73.92%)

1.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6192.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6192.1
2 6192.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
70.13
 Travis Job 6192.2
3 6192.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
69.14
 Travis Job 6192.3
4 6192.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6192.4
5 6192.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6192.5
6 6192.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6192.6
7 6192.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6192.7
8 6192.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6192.8
9 6192.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6192.9
10 6192.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6192.10
Source Files on build 6192
Detailed source file information is not available for this build.