pantsbuild / pants / 6179
0%
main: 93%

LAST BUILD BRANCH: upgrade_runson_to_ami-0a3c71582153db678
DEFAULT BRANCH: main
Ran
Jobs 10
Files 351
Run time 9min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6179

push

travis-ci

jsirois 
Support plugins resolution in pants.

Previously, pants could only load plugins already in the working set
(PYTHONPATH).  With this change, pants both resolves (and caches)
plugins as well as loading backends through their entry points.

In order to support this, two small changes were made to the options
system:

 1. OptionsBootstrapper was altered to cache full options per-known
    scope info set.  This allows the work of bootstrapping to be shared
    by the PluginResolver and the main options loading sequence.
 2. Options was refactored to support creating a copy that behaves the
    same as the original except that option values from command line
    flags are ignored.

These changes combine to give the early stage PluginResolver a clean,
performant means of using the configured PythonSetup and PythonRepos
subsystems to resolve plugins from the repos and indices the user has
set up for their pants installation.

Testing Done:
Manual testing as follows:

1. Bump the pants version in another clone and do a local dry run
   release to build the new entry_points carrying plugins (see:
   https://rbcommons.com/s/twitter/r/2615/)

2. Disable the local android backend:
```diff
$ git diff -U1
diff --git a/pants.ini b/pants.ini
index 4756c9b..d7a67a9 100644
--- a/pants.ini
+++ b/pants.ini
@@ -27,3 +27,3 @@ backend_packages: [
     "internal_backend.utilities",
-    "pants.backend.android",
+#    "pants.backend.android",
     "pants.contrib.cpp",
```

3. Run pants using the new plugin resolver/installed mechanism:
```console
$ rm -rf ~/.cache/pants/plugins/
$ PANTS_PLUGINS="['pantsbuild.pants.backend.android==0.0.42']" PANTS_PYTHON_REPOS_REPOS="['/home/jsirois/dev/3rdparty/jsirois-pants3/dist']" ./pants goals --all
INFO:pants.bin.plugin_resolver:Resolving new plugins...:
  pantsbuild.pants.backend.android==0.0.42
INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants4 on branch jsirois/plugins/bootstrap
Installed goals:
                    apk: Build an android bundle with compiled code and assets.
...
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/75655671

Bugs closed: 1976, 1977

Reviewed at https://rbcommons.com/s/twitter/r/2622/

15522 of 21170 relevant lines covered (73.32%)

1.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6179.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 6179.1
2 6179.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
69.22
 Travis Job 6179.2
3 6179.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
68.81
 Travis Job 6179.3
4 6179.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 6179.4
5 6179.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 6179.5
6 6179.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 6179.6
7 6179.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 6179.7
8 6179.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 6179.8
9 6179.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 6179.9
10 6179.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 6179.10
Source Files on build 6179
Detailed source file information is not available for this build.