aragon / aragon-apps / 7082

97%

push

travis-ci-com

[Internal audit] DisputableVoting (#1256)

* DisputableVoting: rename ChangeRepresentative's event param

* DisputableVoting: generalize public functions and events about quiet ending to use 'configuration'

* DisputableVoting: add internal audit notes

* DisputableVoting: use `getTimestamp()` for comparisons

* DisputableVoting: Fix vote end date computation

* DisputableVoting: Remove stake param from CastVote event

* DisputableVoting: Remove ProxyVoteSuccess event

* DisputableVoting: Store EVM script hash

* DisputableVoting: Mark private functions as internal

* DisputableVoting: Check voters length in `canVoteOnBehalfOf`

* DisputableVoting: Load settings all at once in `_isAccepted`

* DisputableVoting: Optimize Vote struct layout

* DisputableVoting: Rename `quietEndingExtendedSeconds` to `extensionDuration`

* DisputableVoting: Make `settingsLength` public

* DisputableVoting: Change settings-related roles to start with `CHANGE_`

* DisputableVoting: Inline `copySettings`

* DisputableVoting: Inline `_voteOnBehalfOf`

* DisputableVoting: Move `executionDelay` at the end of the Setting struct

* DisputableVoting: Move `getCurrentSettingId()` to mock

* DisputableVoting: Rename `_originalVoteEndDate` to `_baseVoteEndDate`

* DisputableVoting: Rename `votingPower` to `totalPower`

* DisputableVoting: Rename `VoteQuietEndingExtension` to `QuietEndingExtendVote`

* DisputableVoting: Rename `isVoteOpen` to `isVoteOpenForVoting`

* DisputableVoting: Optimize settings loading for some internal functions

* DisputableVoting: Rename `_within*` methods

* DisputableVoting: Rename vote status `Active` to `Normal`

* DisputableVoting: Change "overrule window" for "delegated voting"

* DisputableVoting: Simplify quiet ending bounds computation

* DisputableVoting: avoid publishing Client-based frontend to aragonPM (#1258)

* Agreement: rollback cosmetic changes from DisputableVoting branch

* Agr... (continued)

188 of 196 branches covered (95.92%)

Branch coverage included in aggregate %.

397 of 405 relevant lines covered (98.02%)

36.02 hits per line