aragon / aragon-apps / 7081

97%

push

travis-ci-com

[Internal audit] Agreement (#1254)

* Agreement: cosmetic updates to contract mocks

* Agreement: cosmetic comment polish

* Agreement: update test errors

* Agreement: rename _getDisputableFor() to _getDisputableInfoFor()

* Agreement: cosmetic SLOAD/SSTORE reordering

* Agreement: cosmetic re-ordering of functions

Updates the order to be:

1. Setting
2. Disputable
3. Signing
4. Action, challenge, dispute
5. Misc.

* Agreement: simplify _canClaimSettlement() and _canDispute()

* Agreement: move DisputableAppActivated to be last emitted event

* Agreement: fix challenger evidence not being marked as finished

* Agreement: add audit notes

* agreement: rollback try/catch on disputable callbacks

* agreement: rename actions "current" to "last" challenge

* agreement: allow querying if last challenge is active

* agreement: check disputable is a contract on activation

* agreement: order `changeSetting` params to mimic `initialize`

* agreement: rename some test scenarios

* agreement: add tests for closing evidence submission period

* agreement: support evidence submission after period is closed

* agreement: allow closing evidence period manually

* agreement: generalize safe approvals

* agreement: add initialization check when getting current setting ID

* agreement: add `_unsafe` prefix to internal close action function

* agreement: optimize new action in case of failure

* agreement: add note about submitter in `newAction`

* agreement: organize functions parameters following struct declarations

* agreement: add missing initialization checks

* agreement: inline internal function

* agreement: add ERC165 tests

* agreement: add comment about arbitrator constants

* agreement: fix gas cost tests

* Agreement: polish interface test

* Agreement: polish comments

* Agreement: update order of evidence-related functions

* Agreement: review notes

* Agreement: optimize initi... (continued)

188 of 196 branches covered (95.92%)

Branch coverage included in aggregate %.

397 of 405 relevant lines covered (98.02%)

36.02 hits per line