35067
0%
main: 93%

Ran 23 Aug 2020 08:33AM UTC

Jobs 1

Files 440

Run time 17s

Badge

Embed ▾

pending completion

Build # 35067

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Handle workunits corresponding to canceled Nodes. (#10659)

### Problem

cf. https://github.com/pantsbuild/pants/issues/10650 . When a node is canceled by the engine, the engine will remove the future associated with that node without communicating this fact to the workunit store. This means that the store has no idea that a Started but not yet Completed workunit is never going to complete.

### Solution

This commit adds a `CanceledWorkunitGuard` in the `with_workunit` public interface to workunits. If a workunit completes normally, the last thing it will do is call `not_canceled()` on the guard, and the guard will do nothing. If the guard is dropped before this happens, though, its `Drop` implementation will call a cleanup function on the workunit store to remove the workunit from the heavy hitters and display a log message stating that the workunit has been canceled.

Coverage Stats

0 of 29324 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	35067.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	23 Aug 2020 08:33AM UTC	0	0.0	Travis Job 35067.5

Source Files on build 35067

Detailed source file information is not available for this build.

pantsbuild / pants / 35067
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35067

pantsbuild / pants / 35067 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 35067

pantsbuild / pants / 35067
0%
main: 93%

README BADGES
x