34887
0%
main: 93%

Ran 15 Aug 2020 04:42AM UTC

Jobs 1

Files 440

Run time 27s

Badge

Embed ▾

pending completion

Build # 34887

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Fix log not always showing up when `--dynamic-ui` is set (#10616)

### Problem

Closes https://github.com/pantsbuild/pants/issues/10537. 

### Solution

This seems to have been caused by the fact that the WorkunitStore, which is responsible for printing the "Completed: " log messages when a workunit completes, was previously doing this in HeavyHitters code if `--dynamic-ui` was true, but doing it outside that code if it was false. The HeavyHitters code is periodically called by the dynamic UI code, meaning that it won't be called after the dynamic UI shuts down. This means that it's possible for the last workunits completed by the WorkunitStore to have their completion log messages not printed, because the code that would've printed them is never called because the dynamic UI has already shut down.

The solution to this is to simply print the log message outside of the HeavyHitters code, like the WorkunitStore is already doing in the `--no-dynamic-ui` case.

Coverage Stats

0 of 29050 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	34887.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	15 Aug 2020 04:42AM UTC	0	0.0	Travis Job 34887.5

Source Files on build 34887

Detailed source file information is not available for this build.

pantsbuild / pants / 34887
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34887

pantsbuild / pants / 34887 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34887

pantsbuild / pants / 34887
0%
main: 93%

README BADGES
x