34822
0%
main: 93%

Ran 12 Aug 2020 05:02PM UTC

Jobs 1

Files 439

Run time 2min

Badge

Embed ▾

pending completion

Build # 34822

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Fix regression in unmatched globs error message (#10595)

Fixes https://github.com/pantsbuild/pants/issues/10574. We were calling `throw(&format("{:?}"))` on an error that was already had type `Failure`, meaning that we were converting a `Failure` to a `String`, then back to a `Failure`, which resulted in an overly chatty error message.

This also fixes error messages involving `DownloadFile`.

Before:
```
 Exception: Throw { val: Unmatched glob from file arguments: "fake", python_traceback: "Traceback (no traceback):\n  <pants native internals>\nException: Unmatched glob from file arguments: \"fake\"", engine_traceback: ["Snapshotting: PathGlobs(globs=(\'fake\',), glob_match_error_behavior=<GlobMatchErrorBehavior.error: \'error\'>, conjunction=<GlobExpansionConjunction.all_match: \'all_match\'>, description_of_origin=\'file arguments\')"] }
```

After:

```
Unmatched glob from file arguments: "fake"
```
  
[ci skip-build-wheels]

Coverage Stats

0 of 29034 relevant lines covered (0.0%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	34822.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so PYENV_PY27_VERSION=2.7.18 PYENV_PY36_VERSION=3.6.10 PYENV_PY37_VERSION=3.7.7 PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux PANTS_REMOTE_CA_CERTS_PATH=/usr/lib/google-cloud-sdk/lib/third_party/grpc/_cython/_credentials/roots.pem CACHE_NAME=python_tests.py36)	12 Aug 2020 05:02PM UTC	0	0.0	Travis Job 34822.5

Source Files on build 34822

Detailed source file information is not available for this build.

pantsbuild / pants / 34822
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34822

pantsbuild / pants / 34822 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34822

pantsbuild / pants / 34822
0%
main: 93%

README BADGES
x