pantsbuild / pants / 34791

0%

main: 93%

push

travis-ci-com

Automatically inject dependencies on sibling files when dependency inference is unused (#10582)

### Problem

As of https://github.com/pantsbuild/pants/pull/10511, we now use file addresses / generated subtargets everywhere, except for the graph introspection rules.

By default, generated subtargets do not depend on the sibling files in their base target, i.e. the other files in the original `sources` field. Those dependencies will only be included if dependency inference added it, or if the user explicitly added something like `./sibling.txt` to the base target's `dependencies` field.

We generally do not want to automatically depend on sibling files. This would mean that file addresses (and file dependencies) do not actually have any benefit, because `./pants dependencies $file` would resolve the same results as `./pants dependencies $sibling`, i.e. we would not get finer-grained caching. Further, the conceptual model of "targets as metadata applied to files"—rather than "a collection of files with metadata"—would imply that we should not depend on sibling files automatically.

However, for users who are not using dep inference and/or explicit file deps, many things will break if we don't automatically depend on sibling files. In Pants 1.x, it was a safe assumption that you could access any file in the target's `sources` field without having to add a dependency. It's majorly disruptive to break this assumption, and in effect, they would need to use dependency inference to be ergonomic.

### Solution

Unless `--python-infer-imports` is True, and the target in question has `PythonSources`, then we will automatically add dependencies on all sibling files for file addresses. 

This means that every non-Python target (e.g. `files`, `bash_library`) will depend on its siblings, regardless of using dependency inference.

[ci skip-rust]
[ci skip-build-wheels]

36 of 36 new or added lines in 5 files covered. (100.0%)

0 of 29036 relevant lines covered (0.0%)

0.0 hits per line