pantsbuild / pants / 34643

0%

main: 93%

push

travis-ci-com

Simplify source root stripping. (#10543)

Previously we had two parallel rule paths for stripped and unstripped source files.

This added a lot of complication: various types could contain either stripped or
unstripped sources, and there wasn't always an easy way to know which. This also
required a lot of near-duplication of code, to handle each of the two paths.

This change simplifies the types and rules, as follows:

- Unstripped generic sources are represented by the SourceFiles type.
- Stripped generic sources are represented by the StrippedSourceFiles type.
- Unstripped Python sources are represented by the PythonSourceFiles type,
  which wraps a SourceFiles.
- Stripped Python sources are represented by the StrippedPythonSourceFiles type,
  which wraps a StrippedSourceFiles.

The only way to get a StrippedSourceFiles is to request via a SourceFiles subject.
The only way to get a StrippedPythonSourceFiles is to request it via a PythonSourceFiles subject.

The SourceFiles type carries just enough extra information to allow source-root stripping
even in a merged snapshot, where the originating target information is lost.

As a result, other rules operate primarily on unstripped sources, and strip them just as needed.
For example, finding ancestor files operates only on unstripped sources, and no longer needs
to implement logic to handle the stripped case.

[ci skip-rust]

[ci skip-build-wheels]

152 of 152 new or added lines in 24 files covered. (100.0%)

0 of 29150 relevant lines covered (0.0%)

0.0 hits per line