6001
0%
main: 93%

Ran 05 Aug 2015 06:26PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 6001

Build Type

push

travis-ci

Committed by

dturner-tw

Commit Message

Handle recursive globs with build-file-rev

Previously, build-file-rev with recursive globs would fail in two ways:
1. cmd_line_spec_parser would mistakenly look for the glob directory
in the filesystem even.

2. Some relative paths would contain dot components (e.g. ./foo), and
_realpath_uncached would fail to handle these.

This patch fixes both of these problems.

The recursive glob check had to move inside scan_buildfiles.  To do
so, _isdir became a classmethod, so _isfile and _exists changed too,
for consistency.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/74278317

Reviewed at https://rbcommons.com/s/twitter/r/2572/

Coverage Stats

Jobs

ID	Job ID	Ran
1	6001.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	05 Aug 2015 06:28PM UTC	Travis Job 6001.1
4	6001.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	05 Aug 2015 06:26PM UTC	Travis Job 6001.4
5	6001.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	05 Aug 2015 06:27PM UTC	Travis Job 6001.5
6	6001.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	05 Aug 2015 06:32PM UTC	Travis Job 6001.6
7	6001.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	05 Aug 2015 06:33PM UTC	Travis Job 6001.7
8	6001.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	05 Aug 2015 06:33PM UTC	Travis Job 6001.8
9	6001.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	05 Aug 2015 06:33PM UTC	Travis Job 6001.9
10	6001.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	05 Aug 2015 06:36PM UTC	Travis Job 6001.10

Source Files on build 6001

Detailed source file information is not available for this build.

pantsbuild / pants / 6001
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6001

pantsbuild / pants / 6001 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6001

pantsbuild / pants / 6001
0%
main: 93%

README BADGES
x