19057
89%

Ran 17 Jul 2020 08:44PM UTC

Jobs 1

Files 373

Run time 53s

Badge

Embed ▾

pending completion

Build # 19057

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

api: change ConfigSelector.Result to use callback instead of interceptor

We found that the interceptor approach for `ConfigSelector` would be adding a layer of indirection for no gain: The API Result selectConfig(LoadBalancer.PickSubchannelArgs args) consumes headers among other inputs, because route matching might need to match the headers; and the API produces ClientInterceptor among other outputs. But the headers is not available until clientCall.start(listner, headers), whereas the interceptor need be applied to the call before clientCall.start(). So the input is not available until the output is applied. That means we will need to delay calling the downstream newCall() (which will either be RealChannel or the interceptor) until start() is called.

So we want to change to the other approach similar to what c-core is taking: Have `Result(Object config, CallOptions, Runnable committedCallback)`, where CallOption is the selector modified CallOption, and committedCallback is used to monitor the call lifecycle.

Run Details

23050 of 26552 relevant lines covered (86.81%)

0.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	19057.1 (GRADLE_OPTS=-Xmx512m LDFLAGS=-L/tmp/protobuf/lib CXXFLAGS=-I/tmp/protobuf/include LD_LIBRARY_PATH=/tmp/protobuf/lib)	17 Jul 2020 08:44PM UTC	0	86.81	Travis Job 19057.1

Source Files on build 19057

Detailed source file information is not available for this build.

grpc / grpc-java / 19057
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 19057

grpc / grpc-java / 19057 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 19057

grpc / grpc-java / 19057
89%

README BADGES
x